WINDUPRULE-381: hibernate 5.1-5.3 migration, RegionFactory class usag… #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrizzi
reviewed
Mar 5, 2019
| <where param=""> | ||
| <matches pattern="" /> | ||
| <where param="className"> | ||
| <matches pattern="(cache.RegionFactory|cache.spi.RegionFactory|cache.spi.AbstractRegionFactory|testing.cache.CachingRegionFactory|cache.spi.support.RegionFactoryTemplate)" /> |
There was a problem hiding this comment.
i feel like we should cover "old" classes (CachingRegionFactory, EhCacheRegionFactory, InfinispanRegionFactory, JndiInfinispanRegionFactory, NoCachingRegionFactory, SingletonEhCacheRegionFactory) that are not there anymore analysing org.hibernate.cache.spi.RegionFactory Hibernate 5.1 Javadoc because, afaiu, they removed some of these classes.
mrizzi
reviewed
Mar 5, 2019
Co-Authored-By: m-brophy <36955467+m-brophy@users.noreply.github.com>
Co-Authored-By: m-brophy <36955467+m-brophy@users.noreply.github.com>
Co-Authored-By: m-brophy <36955467+m-brophy@users.noreply.github.com>
…ulesets into WINDUPRULE-381
|
followed up by #366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e review
https://issues.jboss.org/browse/WINDUPRULE-381