WINDUPRULE-379 EAP 7.2 Migration: Hibernate ORM 5.1 to Hibernate ORM … #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5.3 App Migration - references to org.hibernate.HibernateException
mrizzi
requested changes
Mar 5, 2019
There was a problem hiding this comment.
Please remove the .gitignore file from this commit.
I suggested some other changes to the rule
Co-Authored-By: PhilipCattanach <31246010+PhilipCattanach@users.noreply.github.com>
Co-Authored-By: PhilipCattanach <31246010+PhilipCattanach@users.noreply.github.com>
Co-Authored-By: PhilipCattanach <31246010+PhilipCattanach@users.noreply.github.com>
Co-Authored-By: PhilipCattanach <31246010+PhilipCattanach@users.noreply.github.com>
|
Applied changes requested in the PR. The test.xml had to be changed to to ensure the issue count was correct. Also renamed the class name and constructor name in the .java file. Retested locally and the quotes in the message body serve to highlight the class and property names. Also the link takes the user to the Exception section of the document. Thanks Marco - All of these changes add value. |
mrizzi
approved these changes
Mar 6, 2019
|
Once the builds will work, i'll merge this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…5.3 App Migration - references to org.hibernate.HibernateException