Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINDUPRULE-381: hibernate 5.1-5.3 migration, RegionFactory class usag… #366

Merged
merged 4 commits into from
Mar 6, 2019
Merged

WINDUPRULE-381: hibernate 5.1-5.3 migration, RegionFactory class usag… #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e326d81
WINDUPRULE-381: hibernate 5.1-5.3 migration, RegionFactory class usag…
m-brophy Mar 6, 2019
4bdaae8
Update rules-reviewed/eap7/eap71/hibernate51-53.windup.xml
mrizzi Mar 6, 2019
4b164fd
Update rules-reviewed/eap7/eap71/hibernate51-53.windup.xml
mrizzi Mar 6, 2019
013fb75
Update rules-reviewed/eap7/eap71/tests/hibernate51-53.windup.test.xml
mrizzi Mar 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 13 additions & 4 deletions rules-reviewed/eap7/eap71/hibernate51-53.windup.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,17 +224,26 @@
</hint>
</perform>
</rule>
<!--https://issues.jboss.org/browse/WINDUPRULE-381
<!--https://issues.jboss.org/browse/WINDUPRULE-381 -->
<rule id="hibernate51-53-00500">
<when>
<javaclass references="org.hibernate.{className}" >
<location>IMPORT</location>
</javaclass>
</when>
<perform>
<hint title="Hibernate 5.3 - RegionFactory usage" effort="3" category-id="mandatory">
<message>Review usage of classes in `org.hibernate.cache.spi.RegionFactory`, as SPIs for this class has changed.
See Javadoc for `org.hibernate.cache.spi.RegionFactory` for details.</message>
<link title="Red Hat JBoss EAP 7.2: Migrating from Hibernate ORM 5.1 to Hibernate ORM 5.3" href="https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/7.2/html-single/migration_guide/#migrating_from_hibernate_5_1_to_5_3"/>
<link title="Javadoc for org.hibernate.cache.spi.RegionFactory" href="https://docs.jboss.org/hibernate/orm/5.3/javadocs/org/hibernate/cache/spi/RegionFactory.html"/>
<tag>hibernate</tag>
</hint>
</perform>
<where param="">
<matches pattern="" />
<where param="className">
<matches pattern="(cache.RegionFactory|cache.spi.RegionFactory|cache.spi.AbstractRegionFactory|testing.cache.CachingRegionFactory|cache.spi.support.RegionFactoryTemplate|cache.ehcache.EhCacheRegionFactory|cache.infinispan.InfinispanRegionFactory|cache.infinispan.JndiInfinispanRegionFactory|cache.internal.NoCachingRegionFactory|cache.ehcache.SingletonEhCacheRegionFactory)" />
</where>
</rule>
-->
<!--https://issues.jboss.org/browse/WINDUPRULE-382-->
<rule id="hibernate51-53-00600">
<when>
Expand Down
17 changes: 17 additions & 0 deletions rules-reviewed/eap7/eap71/tests/data/data-hibernate51-53/Hibernate515300500.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import org.hibernate.cache.RegionFactory;
import org.hibernate.cache.spi.RegionFactory;
import org.hibernate.cache.spi.AbstractRegionFactory;
import org.hibernate.testing.cache.CachingRegionFactory;
import org.hibernate.cache.spi.support.RegionFactoryTemplate;
import org.hibernate.cache.ehcache.EhCacheRegionFactory;
import org.hibernate.cache.ehcache.SingletonEhCacheRegionFactory;
import org.hibernate.cache.infinispan.InfinispanRegionFactory
import org.hibernate.cache.infinispan.JndiInfinispanRegionFactory;
import org.hibernate.cache.internal.NoCachingRegionFactory;

public class Hibernate515300500 {

public void aMethod(String queryString) {
queryString.toLowerCase();
}
}
9 changes: 4 additions & 5 deletions rules-reviewed/eap7/eap71/tests/hibernate51-53.windup.test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,20 +159,19 @@
<fail message="Hint removed method getAllSecondLevelCacheRegions() not found" />
</perform>
</rule>
<!--https://issues.jboss.org/browse/WINDUPRULE-381
<!--https://issues.jboss.org/browse/WINDUPRULE-381 -->
<rule id="hibernate51-53-00500-test">
<when>
<not>
<iterable-filter size="5">
<hint-exists message="" />
<iterable-filter size="10">
<hint-exists message="Review usage of classes in `org.hibernate.cache.spi.RegionFactory`" />
</iterable-filter>
</not>
</when>
<perform>
<fail message="" />
<fail message="RegionFactory references not flagged as required" />
</perform>
</rule>
-->
<!--https://issues.jboss.org/browse/WINDUPRULE-382-->
<rule id="hibernate51-53-00600-test">
<when>
Expand Down