Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINDUPRULE-370: resteasy resource method algorithm changes #367

Merged
merged 4 commits into from Mar 8, 2019
Merged

WINDUPRULE-370: resteasy resource method algorithm changes #367

merged 4 commits into from Mar 8, 2019

Conversation

m-brophy
Copy link
Contributor

@m-brophy m-brophy commented Mar 7, 2019 •
edited by mrizzi

@PhilipCattanach
Copy link
Contributor

I have checked the code and executed the tests. All looks good. I will squash and merge as soon as the automated checks pass. Thanks.

mrizzi
mrizzi requested changes Mar 7, 2019
View reviewed changes
Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the rule @m-brophy.

I added some changes for consistency with other rules sets.
Please change also the ruleset file name to be resteasy30-36.windup.xml

rules-reviewed/eap7/eap71/resteasy-resource-method.windup.xml Outdated Show resolved Hide resolved
rules-reviewed/eap7/eap71/resteasy-resource-method.windup.xml Outdated Show resolved Hide resolved
rules-reviewed/eap7/eap71/resteasy-resource-method.windup.xml Outdated Show resolved Hide resolved
rules-reviewed/eap7/eap71/resteasy-resource-method.windup.xml Outdated Show resolved Hide resolved
rules-reviewed/eap7/eap71/tests/resteasy-resource-method.windup.test.xml Outdated Show resolved Hide resolved
rules-reviewed/eap7/eap71/tests/resteasy-resource-method.windup.test.xml Outdated Show resolved Hide resolved
rules-reviewed/eap7/eap71/tests/resteasy-resource-method.windup.test.xml Outdated Show resolved Hide resolved
rules-reviewed/eap7/eap71/tests/resteasy-resource-method.windup.test.xml Outdated Show resolved Hide resolved
rules-reviewed/eap7/eap71/resteasy-resource-method.windup.xml Outdated Show resolved Hide resolved
rules-reviewed/eap7/eap71/resteasy-resource-method.windup.xml Outdated Show resolved Hide resolved
mrizzi
mrizzi requested changes Mar 7, 2019
View reviewed changes
Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please change the ruleset name from resteasy-30-36.windup.xml to resteasy30-36.windup.xml otherwise the test won't find the file

mrizzi
mrizzi requested changes Mar 8, 2019
View reviewed changes
Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I promise: this is the last change i require 😉

rules-reviewed/eap7/eap71/resteasy30-36.windup.xml Outdated Show resolved Hide resolved
@mrizzi @m-brophy
Update rules-reviewed/eap7/eap71/resteasy30-36.windup.xml
1a89b57 
Co-Authored-By: m-brophy <36955467+m-brophy@users.noreply.github.com>
@PhilipCattanach
Copy link
Contributor

I can see the resteasy targetTechnology tag in the rule and the appropriate characters to highlight the property and value in the message. The Test runs successfully, the appropriate words highlighted, and the link takes you to the relevant part of the docs. All good.

@mrizzi mrizzi merged commit 50c5c61 into windup:master Mar 8, 2019
@m-brophy m-brophy deleted the WINDUPRULE-370 branch March 28, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrizzi mrizzi mrizzi approved these changes

@PhilipCattanach PhilipCattanach Awaiting requested review from PhilipCattanach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@m-brophy @PhilipCattanach @mrizzi