Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windup 2203 eap javaee rules #370

Merged
merged 8 commits into from Mar 26, 2019

Conversation

jonathanvila
Copy link
Member

@jonathanvila jonathanvila commented Mar 21, 2019

Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems everything is fine with this PR (there's only need for the fix that @m-brophy requested).
After the fix will be pushed (and the builds will be successful), i'll merge this.

Thanks @jonathanvila

Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything has been fine with the builds.

@mrizzi mrizzi merged commit eaaf008 into windup:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants