WINDUPRULE-404: eap 7.3 maven-artemis-jms-client rules #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please do not merge, to be fixed once EAP 7.3 is released |
m-brophy
reviewed
Jan 15, 2020
mrizzi
reviewed
Jan 22, 2020
rules-reviewed/eap7/eap72/tests/maven-artemis-jms-client.rhamt.test.xml
Outdated
Show resolved
Hide resolved
emmartins
force-pushed
the
WINDUPRULE-404
branch
2 times, most recently
from
1c77917
to
93277f8
Compare
mrizzi
reviewed
Jan 24, 2020
rules-reviewed/eap7/eap72/tests/maven-artemis-jms-client.rhamt.test.xml
Outdated
Show resolved
Hide resolved
emmartins
force-pushed
the
WINDUPRULE-404
branch
from
93277f8
to
f39a8ac
Compare
mrizzi
approved these changes
Jan 24, 2020
There was a problem hiding this comment.
The rule is fine.
The current failure in the build is related to:
[main] ERROR org.jboss.windup.rules.tests.WindupRulesLinksTest - Response code 404 for https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/7.3/html-single/migration_guide/index#migrate_messaging_application_changes_7_2
which is supposed to happen since this doc is not publicly available yet.
|
It has been decided to merge this PR even if the link test fails because the documentation link has been manually tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.jboss.org/browse/WINDUPRULE-404