Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUPRULE-422 @ContextName and @ContextNames have been removed #395

Merged
merged 2 commits into from Jan 24, 2020

Conversation

johnpoth
Copy link
Contributor

@windupgithubbot1
Copy link

Can one of the admins verify this patch?

@mrizzi
Copy link
Member

mrizzi commented Jan 14, 2020

test this please

@johnpoth
Copy link
Contributor Author

@mrizzi do you know when this could be merged ? Thanks !

Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just proposed a change to the effort to be consistent with RHAMT's docs.
If the change is fine for you @johnpoth, please just accept it and then the rule will be ready to be merged since it looks very good to me.

…pplication-not-supported.windup.xml

Co-Authored-By: Marco Rizzi <mrizzi@users.noreply.github.com>
@johnpoth
Copy link
Contributor Author

@mrizzi those changes are fine with me! Thanks for reviewing! I'll update my code with the link you sent me regarding story points

@mrizzi
Copy link
Member

mrizzi commented Jan 24, 2020

retest

Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule looks good @johnpoth, thanks a lot 👍

@mrizzi mrizzi merged commit 8495c82 into windup:master Jan 24, 2020
@johnpoth johnpoth deleted the WINDUPRULE-422 branch January 24, 2020 18:38
@johnpoth
Copy link
Contributor Author

Thanks @mrizzi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants