Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUPRULE-676 Rules for components with 1:1 matching with a Quarkus extension #516

Merged
merged 19 commits into from Dec 14, 2020

Conversation

mrizzi
Copy link
Member

@mrizzi mrizzi commented Nov 5, 2020

https://issues.redhat.com/browse/WINDUPRULE-676

Agreed upon reviewing 4 rulesets as the meaningful one to validate the overall PR since it's based on the same approach to generate every ruleset:

Put on hold for the review:

  • agroal
  • artemis
  • config
  • elytron
  • jdbc
  • jsonb
  • jsonp
  • keycloak
  • kubernetes-client
  • logging
  • narayana
  • openshift-client
  • resteasy

Copy link
Member Author

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added quarkus-amazon-lambda-xray guide's URL

rules-reviewed/quarkus/amazon/amazon-to-quarkus.windup.xml Outdated Show resolved Hide resolved
Copy link
Member Author

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 17 (out of 24) generic (and to be evaluated/improved) links to be provided in rules (currently referring to https://quarkus.io/guides/)

Copy link
Member Author

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add further comments to the remaining guides' links.

@m-brophy m-brophy merged commit 57215f4 into windup:master Dec 14, 2020
@mrizzi mrizzi deleted the WINDUPRULE-676 branch December 14, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants