-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WINDUPRULE-708 Quarkus Release 1.11 - Jackson #523
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-brophy
reviewed
Jan 28, 2021
rules-reviewed/quarkus/quarkus1-10/tests/quarkus1-11-resteasy-jackson-compiled.windup.test.xml
Outdated
Show resolved
Hide resolved
m-brophy
reviewed
Jan 28, 2021
rules-reviewed/quarkus/quarkus1-10/tests/quarkus1-11-resteasy-jackson.windup.test.xml
Outdated
Show resolved
Hide resolved
Thanks Mark, I'll make that change and update the PR.
…On Thu, Jan 28, 2021 at 1:03 PM Mark Brophy ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
rules-reviewed/quarkus/quarkus1-10/tests/quarkus1-11-resteasy-jackson.windup.test.xml
<#523 (comment)>
:
> @@ -0,0 +1,24 @@
+<?xml version="1.0"?>
+<ruletest id="quarkus1-11-resteasy-jackson-tests"
+ xmlns="http://windup.jboss.org/schema/jboss-ruleset"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://windup.jboss.org/schema/jboss-ruleset http://windup.jboss.org/schema/jboss-ruleset/windup-jboss-ruleset.xsd">
+ <testDataPath>data/</testDataPath>
+ <rulePath>../quarkus1-11-resteasy-jackson.windup.xml</rulePath>
+ <ruleset>
+ <rules>
+ <rule id="quarkus1-11-resteasy-jackson-test">
by convention we usually name tests the same as the rule they're testing
with "-test" on the end
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#523 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHOMNOW7ACO2G7UK7PXGSMTS4FOAJANCNFSM4WVONMDQ>
.
--
Phil Cattanach
MTA and MA Manager
Red Hat UK Ltd.
e-mail: pcattana@redhat.com
m: +44 745 3945 257
|
m-brophy
approved these changes
Jan 29, 2021
mrizzi
approved these changes
Feb 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After @m-brophy's approval, only the source and target names have been changed and the tests ran successfully.
Thanks @PhilipCattanach 👍
m-brophy
pushed a commit
to m-brophy/windup-rulesets
that referenced
this pull request
Feb 4, 2021
* WINDUPRULE-708 Quarkus Release 1.11 - Jackson (windup#523) * WINDUPRULE-708 Quarkus Release 1.11 - Jackson * WINDUPRULE-708 - rename tests to be consistent with rules * WINDUPRULE-708 changed to quarkus1 target so new quarkus1 folder under rules-reviewed Co-authored-by: Phil Cattanach <pcattana@pcattana.remote.csb> * WINDUPRULE-710 Divived Groovy rule in two different rules Co-authored-by: PhilipCattanach <31246010+PhilipCattanach@users.noreply.github.com> Co-authored-by: Phil Cattanach <pcattana@pcattana.remote.csb>
jonathanvila
pushed a commit
that referenced
this pull request
Feb 8, 2021
…rch (#524) * WINDUPRULE-710: rules for quarkus upgrade of hibernate-orm-elasticsearch * WINDUPRULE-710 Divived Groovy rule in two different rules (#7) * WINDUPRULE-708 Quarkus Release 1.11 - Jackson (#523) * WINDUPRULE-708 Quarkus Release 1.11 - Jackson * WINDUPRULE-708 - rename tests to be consistent with rules * WINDUPRULE-708 changed to quarkus1 target so new quarkus1 folder under rules-reviewed Co-authored-by: Phil Cattanach <pcattana@pcattana.remote.csb> * WINDUPRULE-710 Divived Groovy rule in two different rules Co-authored-by: PhilipCattanach <31246010+PhilipCattanach@users.noreply.github.com> Co-authored-by: Phil Cattanach <pcattana@pcattana.remote.csb> * WINDUPRULE-710: fix wrongly removed tag in pom file Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: PhilipCattanach <31246010+PhilipCattanach@users.noreply.github.com> Co-authored-by: Phil Cattanach <pcattana@pcattana.remote.csb>
jonathanvila
pushed a commit
that referenced
this pull request
Feb 9, 2021
* WINDUPRULE-710: rules for quarkus upgrade of hibernate-orm-elasticsearch * WINDUPRULE-710 Divived Groovy rule in two different rules (#7) * WINDUPRULE-708 Quarkus Release 1.11 - Jackson (#523) * WINDUPRULE-708 Quarkus Release 1.11 - Jackson * WINDUPRULE-708 - rename tests to be consistent with rules * WINDUPRULE-708 changed to quarkus1 target so new quarkus1 folder under rules-reviewed Co-authored-by: Phil Cattanach <pcattana@pcattana.remote.csb> * WINDUPRULE-710 Divived Groovy rule in two different rules Co-authored-by: PhilipCattanach <31246010+PhilipCattanach@users.noreply.github.com> Co-authored-by: Phil Cattanach <pcattana@pcattana.remote.csb> * WINDUPRULE-710: fix wrongly removed tag in pom file * WINDUPRULE-710: change elasticsearch target to quarkus1 and refactor rules into logical grouping Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: PhilipCattanach <31246010+PhilipCattanach@users.noreply.github.com> Co-authored-by: Phil Cattanach <pcattana@pcattana.remote.csb>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.