Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WINDUPRULE-759] eapxp_bootable_jar_maven_plugin_configuration_change… #559

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

emmartins
Copy link
Contributor

@emmartins
Copy link
Contributor Author

Please note that the link is pointing to a staged document

@emmartins
Copy link
Contributor Author

@mrizzi could this could be improved with a quick fix that would replace the XML element name?

@PhilipCattanach
Copy link
Contributor

@emmartins - (as with the other PR) I have reviewed the code and tested this rules set. Everything looks fine. Thank you!
The link didn't work but I presume this is because the guide hasn't been published yet?
Marco is working on a fix windup/windup#1417 for some Eclipse dependencies issues that should be merged to master shortly and will allow the default tests above to complete. When those things are done I'll merge this to master.

@emmartins
Copy link
Contributor Author

@PhilipCattanach the link should work if you log in to customer portal, it's a staged one. Once published all needed should be to remove the ?lb_target=stage from the URL

@mrizzi
Copy link
Member

mrizzi commented Jul 6, 2021

retest

@emmartins
Copy link
Contributor Author

updated to remove the "?lb_target=stage" part of the link (please note the doc is not yet published tho)

@PhilipCattanach
Copy link
Contributor

@jonathanvila
Copy link
Member

retest

1 similar comment
@jonathanvila
Copy link
Member

retest

@PhilipCattanach PhilipCattanach merged commit 8ef53cf into windup:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants