WINDUPRULE-826 SB2Quarkus Swagger and OpenAPI property settings #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-brophy
reviewed
Mar 24, 2022
| <perform> | ||
| <hint title="Replace Spring OpenAPI endpoint mapping" effort="1" category-id="mandatory"> | ||
| <message> | ||
| Replace `springdoc.api-docs.path` with `quarkus.smallrye-openapi.path` |
There was a problem hiding this comment.
do we need to add something here to mention changing =/openapi to =/swagger-ui?
There was a problem hiding this comment.
Hi @m-brophy ,
in both cases the value on the right side of the is consistent, after moving to quarkus.
It is just the name of the property that needs to be changed.
This is the solution view of the file https://github.com/RedHat-Middleware-Workshops/spring-to-quarkus-todo/blob/solution/src/main/resources/application.properties
This is the original SB version of the file
https://github.com/RedHat-Middleware-Workshops/spring-to-quarkus-todo/blob/main/src/main/resources/application.properties
m-brophy
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains rules for WINDUPRULE-826 and WINDUPRULE-827
They are both very similar in that they are SB2Quarkus rules pertaining to properties for Swagger and Open API respectively.
These rules originate from this tutorial https://github.com/RedHat-Middleware-Workshops/spring-to-quarkus-todo#migrate-data-source-properties