Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAP 6 -> EAP 7 #67

Merged
merged 9 commits into from
Nov 10, 2015
Merged

EAP 6 -> EAP 7 #67

merged 9 commits into from
Nov 10, 2015

Conversation

mbriskar
Copy link
Contributor

I lost a battle with rebasing for the first commit :-). The first commit: I took Eduardo's commits, squashed them into one and did small changes (introduced metadata + changed positions of files).

This should be ready, I just have 2 comments:
1.) documentation links are not provided yet.
2.) there is no way how to test < xslt > now (I have created an issue for this https://issues.jboss.org/browse/WINDUP-733 )

<!-- TODO: Migrate this link tom some JBoss + OpenEJB generates it automatically? -->
<message>CMP entity beans are no longer supported in JBoss EAP 7. User is requested to use JPA entity beans that fully replaced the functionality provided by CMP beans.
This entity needs to be migrated using JPA persistence.xml or using JPA annotations.</message>
<link title="CMP Bean to JPA migration" href="http://what-when-how.com/enterprise-javabeans-3/migrating-cmp-2-entity-beans-to-the-ejb-3-jpa-part-1/"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link should be probably migrated to access.redhat or? It looks good. + I found out that OpenEJB implementation is able to migrate from CMP to JPA automatically. Maybe there would be a way how to use it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the effort should be "5" as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You suggest putting 5 for every entity?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It is a big migration in my opinion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is that I also find a configuration file that configurates these CMP beans. Isn't enough to put about 20 there and then less for each entity? (not sure even if that configuration file is mandatory, just an idea)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eap6-xml-01000 in eap6-xml.windup.xml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you're suggesting that the configuration file have a higher weight than the individual bean container managed persistence bean references?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because the configuration may be reflecting CMP migration as a whole whereas beans may reflect just one simple bean migration. That's my point of view.. However I still lack a way how to put some effort to group of hints but just once. E.g where else to put effort for the CMP migration as a whole?

<dependencies>
<addon id="org.jboss.windup.rules,windup-rules-xml,2.3.0.Final" />
</dependencies>
<sourceTechnology id="weblogic" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weblogic shouldn't be here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

< sourceTechnology id="eap" versionRange="[6,7)" / >
< targetTechnology id="eap" versionRange="[7,)" / >

</when>
<perform>
<iteration>
<hint title="Valve is not supported in JBoss EAP 7." effort="0" severity="mandatory">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

effort 0 for something that is not supported yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants