WINDUPRULE-898 EAP8 RESTEasy rules #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rty to interceptors rule
m-brophy
reviewed
Jan 16, 2023
| </or> | ||
| </when> | ||
| <perform> | ||
| <hint title="The org.jboss.resteasy.resteasy-jettison-provider module has been removed" effort="5" category-id="mandatory"> |
There was a problem hiding this comment.
Should this effort be 13 for now, ie Unknown rather than 5, Redesign until we have some concrete method of what to do in this case?
| </project> | ||
| </when> | ||
| <perform> | ||
| <hint title="The org.jboss.resteasy resteasy-jettison-provider artifact has been removed" effort="5" category-id="mandatory"> |
There was a problem hiding this comment.
Again, would this be better as effort="13" for now?
| </project> | ||
| </when> | ||
| <perform> | ||
| <hint title="The org.jboss.resteasy resteasy-yaml-provider artifact has been removed" effort="5" category-id="mandatory"> |
There was a problem hiding this comment.
should it be effort="13"?
| </or> | ||
| </when> | ||
| <perform> | ||
| <hint title="The org.jboss.resteasy.resteasy-yaml-provider module has been removed" effort="5" category-id="mandatory"> |
There was a problem hiding this comment.
should it be effort="13"?
Co-authored-by: Mark Brophy <36955467+m-brophy@users.noreply.github.com>
mrizzi
reviewed
Jan 17, 2023
| </when> | ||
| <perform> | ||
| <hint title="The org.jboss.resteasy resteasy-jettison-provider artifact has been removed" effort="5" category-id="mandatory"> | ||
| <message>The `org.jboss.resteasy` `resteasy-jettison-provider` artifact has been removed. There is no documented solution for this issue.</message> |
There was a problem hiding this comment.
Suggested change
| <message>The `org.jboss.resteasy` `resteasy-jettison-provider` artifact has been removed. There is no documented solution for this issue.</message> | |
| <message>The `org.jboss.resteasy:resteasy-jettison-provider` artifact has been removed. There is no documented solution for this issue.</message> |
There was a problem hiding this comment.
That will require a change to the test as well
|
Hi @m-brophy |
mrizzi
added
auto-backport
github-actions bot
pushed a commit
that referenced
this pull request
Feb 23, 2023
* [WINDUPRULE-903] Migration from Keycloak to Native EAP OpenID Connect Support * [WINDUPRULE-903] Fix test * WINDUPRULE-898 EAP8 RESTEasy rules * WINDUPRULE-898 EAP 8 RESTEasy add mention of resteasy.allowGzip property to interceptors rule * Update rules/rules-reviewed/eap8/eap6/eap8-resteasy.windup.xml Co-authored-by: Mark Brophy <36955467+m-brophy@users.noreply.github.com> * WINDUPRULE-898 eap8 resteasy PR feedback corrections --------- Co-authored-by: Juan Manuel Leflet Estrada <jleflete@redhat.com> Co-authored-by: Mark Brophy <36955467+m-brophy@users.noreply.github.com> (cherry picked from commit 14c088c)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mrizzi
pushed a commit
that referenced
this pull request
Feb 23, 2023
* [WINDUPRULE-903] Migration from Keycloak to Native EAP OpenID Connect Support * [WINDUPRULE-903] Fix test * WINDUPRULE-898 EAP8 RESTEasy rules * WINDUPRULE-898 EAP 8 RESTEasy add mention of resteasy.allowGzip property to interceptors rule * Update rules/rules-reviewed/eap8/eap6/eap8-resteasy.windup.xml Co-authored-by: Mark Brophy <36955467+m-brophy@users.noreply.github.com> * WINDUPRULE-898 eap8 resteasy PR feedback corrections --------- Co-authored-by: Juan Manuel Leflet Estrada <jleflete@redhat.com> Co-authored-by: Mark Brophy <36955467+m-brophy@users.noreply.github.com> (cherry picked from commit 14c088c) Co-authored-by: PhilipCattanach <31246010+PhilipCattanach@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mark,
When you get a moment can you review this ruleset please?
Please have a look at the document attached to the Jira just to be sure that I've covered all of the issues.
No rush.
Thanks,
Phil