[WINDUPRULE-900] Create ruleset for hibernate search 5 to 6 migration

[jmle]

See Jira ticket.
All rules extracted from the migration guide.

[PhilipCattanach]

@jmle - First off let me say thanks you for the huge amount of work that you have put into this ruleset.
I checked all of the 6.0 Migration Guide off against the rules and didn't find any gaps. Very well done.

The first point in the name of the rules file. It is misspelled hibiernate-search instead of hibernate-search and the corresponding test.windup.xml file should have the rulePath element pointing back to the hibernate-search.windup.xml file.
My next point is about the target. Shouldn't the eap targetTechnology be versionRange="[8,)"

However I also think that we should have targetTechnology id="hibernate" versionRange="[6,)"

I think we also need to do is have another ruleset for the issues in https://docs.jboss.org/hibernate/search/6.1/migration/html_single/ ?

The ruleset to cover the 6.1 rules should have 2 targets as well
targetTechnology id="eap" versionRange="[8,)"
targetTechnology id="hibernate" versionRange="[6.1,)"

I'll continue with my testing and let you know if I spot anything else.
Thanks again.

[PhilipCattanach]

@jmle - I have submitted a PR for the (6.0) issues in the comment above. Thanks.

[yrodiere]

That's awesome, thanks a lot for working on this.

I'm not sure I spotted everything (this is a lot of work!) but I did notice what looks like a mistake.

[yrodiere]

However I also think that we should have targetTechnology id="hibernate" versionRange="[6,)"

Note that Hibernate Search 6.0 is only compatible with Hibernate ORM 5.4 to 5.6. See https://hibernate.org/search/releases/6.0/#compatibility

Hibernate Search 6.1+ is still compatible with Hibernate ORM 5.6 by default, but can also work with Hibernate ORM 6.0+ through different Maven artifacts; see https://docs.jboss.org/hibernate/search/6.2/reference/en-US/html_single/#other-integrations-orm6
Those -orm6 artifacts are the only ones shipped with EAP 8.

[jmle]

However I also think that we should have targetTechnology id="hibernate" versionRange="[6,)"

Note that Hibernate Search 6.0 is only compatible with Hibernate ORM 5.4 to 5.6. See https://hibernate.org/search/releases/6.0/#compatibility

Hibernate Search 6.1+ is still compatible with Hibernate ORM 5.6 by default, but can also work with Hibernate ORM 6.0+ through different Maven artifacts; see https://docs.jboss.org/hibernate/search/6.2/reference/en-US/html_single/#other-integrations-orm6 Those -orm6 artifacts are the only ones shipped with EAP 8.

@PhilipCattanach I just merged your PR and afterwards I saw this. We might need to make an additional rule/ruleset to cater for the Hibernate ORM dependency versions when migrating, if I understood correctly

[yrodiere]

As requested, I reviewed this in full.

I think I spotted everything there was to spot, but it's a large PR :)

Details below.

[github-actions]

💚 All backports created successfully

Status	Branch	Result
✅	releases/6.1.z

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details