-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the wrong '[eb-s]' pattern #950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking the WindupRulesTest (temurin, rules-reviewed/\(\(e[^a]\)\|[f-s]\), 11)
build's log, it turned out this is the list of the executed rules:
$ grep -e 'file:.*.xml.*\] matched' 6_Test.txt | cut -d' ' -f6 | sort | uniq
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/fuse-service-works/soa-p-5/soa-p-5.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/fuse/sonic-catchall.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/fuse/sonicesb/sonic-esb.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/fuse/sonicesb/xml-sonic-esb.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/hibernate/hibernate-catchall.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/hibernate/hibernate.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/hibernate/hibernate-xml.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openjdk11/openjdk8/java-removals.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openjdk11/openjdk8/removed-javaee-modules.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openjdk17/openjdk11/applet-api-deprecation.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openjdk17/openjdk11/lombok.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openjdk17/openjdk11/removed-classes.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openjdk17/openjdk11/removed-packages.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openjdk17/openjdk11/security-manager-deprecation.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openjdk7/oraclejdk7/oracle2openjdk.rhamt.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openliberty/websphere/liberty-java-unavailable-technologies.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openliberty/websphere/liberty-websphere-unavailable-technologies.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openshift/embedded-cache-libraries.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openshift/java-rmi.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openshift/java-rpc.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openshift/jca.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openshift/jni-native-code.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openshift/local-storage.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openshift/logging.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openshift/mail.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openshift/session.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/openshift/socket-communication.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/os/windows/os-specific.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/java-ee/cdi-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/java-ee/javaee-pom-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/java-ee/jaxrs-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-actuator-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-annotations-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-cache-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-cloud-config-client-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-data-jpa-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-devtools-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-di-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-generic-catchall.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-integration-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-jmx-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-metrics-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-parent-pom-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-plugins-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-properties-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-scheduled-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-security-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-shell-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-webmvc-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/quarkus/springboot/springboot-web-to-quarkus.windup.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/rhr/springboot/springboot-associated-artifacts.rhamt.xml
file:/home/runner/work/windup-rulesets/windup-rulesets/rules/rules-reviewed/rhr/springboot/springboot-rhr.rhamt.xml
They're the full set of expected rules to be tested within this job.
(cherry picked from commit 8723e66)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
In GH Jobs for PRs, the
rules-reviewed/[eb-s]
always takes longer (~25 minutes) than any other job (usually ~5 minutes).It turned out the
[eb-s]
range is wrong so it has been changed to be((e[^a])|[f-s])
, i.e.:e
butea
f-s
range