Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rules to detect eureka and config server connection string in azure #954

Conversation

KaiqianYang
Copy link
Contributor

No description provided.

@PhilipCattanach
Copy link
Contributor

PR linked to Jira https://issues.redhat.com/browse/WINDUPRULE-988

@PhilipCattanach
Copy link
Contributor

Hi @KaiqianYang
The rules look good. can I just request that the technology-tag 'config sever' is replaced by 'Spring Cloud Config'
Just for information this file is a useful list of the Technology Tags we have in windup rules
https://github.com/windup/windup-rulesets/tree/master/rules/rules-reviewed#embedded

@KaiqianYang
Copy link
Contributor Author

Hi @KaiqianYang The rules look good. can I just request that the technology-tag 'config sever' is replaced by 'Spring Cloud Config' Just for information this file is a useful list of the Technology Tags we have in windup rules https://github.com/windup/windup-rulesets/tree/master/rules/rules-reviewed#embedded

Hi @PhilipCattanach
Thank you for the information and the useful list of Technology Tags. And I have updated the 'config server' to 'Spring Cloud Config' as suggested.

@PhilipCattanach
Copy link
Contributor

Reviewed and tested successfully. Thank you!

@PhilipCattanach PhilipCattanach merged commit 124a9d6 into windup:master May 23, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants