Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUP-1552 Enhance OCP deployment script #33

Merged
merged 1 commit into from Jul 14, 2017

Conversation

mrizzi
Copy link
Member

@mrizzi mrizzi commented Jul 13, 2017

Major change:

  • the script waits for the rhamt-web-console pod to be ready before writing to console the URL to browse to
  • fixed rhamt-web-console pod search:
    • no more false positive with the rhamt-web-console-2-deploy pod
    • no more false positive when rhamt-web-console pod is not ready

Minor enhancements

  • added . while waiting for image stream tag to become available
  • added verified after founding image stream tag (consistency with created suffix in the output of oc commands)
  • added commented [OK] (font color light green) for future development
  • added [KO] (font color light red) if there are no image stream tag
  • added . while deploy to finish
  • if the deployoment is:

Tested on Openshift Dedicated and CDKv3.

M=$[${M}+1]
sleep 5
fi
done
if [ ${M} -eq 50 ]; then
echo -e "\e[91m[KO]\e[39m"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure exactly what "KO" means. Also, shouldn't it exit in this case?

@jsight jsight merged commit 1b0bf4e into windup:master Jul 14, 2017
@mrizzi mrizzi deleted the deploy_script_enhancement branch July 24, 2017 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants