New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WINDUP-1254 #153
WINDUP-1254 #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, I have just 2 comments:
- breadcrumbs are not displayed on active executions page
- I think visibility of the text didn't improve much. Maybe increasing font size could help? Or bold text. Or darker color :) That one is probably the best.
@mareknovotny - +1 to both of David's comments. I do like the idea, though. It looks nice locally, but would probably be better with a slightly larger font size. |
Oops, I broke the Executions list layout then with the last css change. I will look at it. With the next suggestion to font size - I can agree with that even I was focused on positioning and color background changes for WINDUP-1254. Anyway I will try to raise the size to fit the rest of page(s). |
hmm, after hours of discovery why it is not there, i haven't found anything in styles, but noticed that the anchor is generated without text, so it is rendered, but physically the breadcrumbs link is empty. |
Fixes issue with breadcrumbs not visible on global executions list.
It was actually my fault. I forgot to add displayName into global executions list route. |
my try to fix https://issues.jboss.org/browse/WINDUP-1254