Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task 773: Bug when create a new project after a project deletion #327

Merged
merged 1 commit into from
Apr 20, 2017
Merged

Task 773: Bug when create a new project after a project deletion #327

merged 1 commit into from
Apr 20, 2017

Conversation

jsight
Copy link
Member

@jsight jsight commented Apr 19, 2017

@jsight jsight requested a review from mrizzi April 19, 2017 21:26
mrizzi
mrizzi approved these changes Apr 20, 2017
View reviewed changes
Copy link
Member

@mrizzi mrizzi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally and this PR solves the issue.
Flow

  1. empty project list
  2. create a project
  3. run analysis successfully
  4. delete project
  5. create a new one

the old code made two requests

http://localhost:8080/rhamt-web/api/analysis-context/73
http://localhost:8080/rhamt-web/api/migrationProjects/get/72

that throws the javax.ws.rs.NotFoundException exceptions.
With this PR's changes, the remote call are no more done.

@mareknovotny
Copy link
Contributor

retest

@jsight jsight merged commit 38a8b5d into windup:master Apr 20, 2017
@mrizzi
Copy link
Member

mrizzi commented Apr 20, 2017

This solves the issue https://issues.jboss.org/browse/WINDUP-1352

@jsight
Copy link
Member Author

jsight commented Apr 20, 2017

Ah, that was the JIRA that I was thinking of. :) For some reason, I thought there were others.

@jsight jsight deleted the analysis_context_router_unsubscribe branch April 20, 2017 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrizzi mrizzi mrizzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jsight @mareknovotny @mrizzi