Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUP-1382 - Show only MigrationRulesPhase rules #453

Merged
merged 2 commits into from Aug 25, 2017

Conversation

klinki
Copy link
Collaborator

@klinki klinki commented Jun 9, 2017

In rules configuration form, show only migration rules.

#close WINDUP-1382

@klinki
Copy link
Collaborator Author

klinki commented Jun 9, 2017

Marek pointed out there are some relevant rules also in different phases (especially PostMigrationRulesPhase for catch-all rules)

In rules configuration form, show only migration rules.

#close WINDUP-1382
@klinki klinki force-pushed the windup-1382-filter-migration-rules branch from dd2579d to 0501f7d Compare August 15, 2017 11:27
@klinki klinki changed the title Show only MigrationRulesPhase rules WINDUP-1382 - Show only MigrationRulesPhase rules Aug 15, 2017
Copy link
Contributor

@mareknovotny mareknovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine, except that I noticed the rule list contains also *Phases as ruleset/RuleProviders. I think this is wrong. it was there before this PR, but we could perhaps filter these phases too

@jsight jsight merged commit c1a9c4b into windup:master Aug 25, 2017
@klinki klinki deleted the windup-1382-filter-migration-rules branch August 28, 2017 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants