Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINDUP-1433 #455

Merged
merged 1 commit into from Jun 13, 2017
Merged

WINDUP-1433 #455

merged 1 commit into from Jun 13, 2017

Conversation

mareknovotny
Copy link
Contributor

@jsight
Copy link
Member

jsight commented Jun 12, 2017

The problem is that the build requires unzipping the files as well. Unzipping the archive still produces a directory with the full version in it and that means that the code needs to deal with the version as well. Perhaps the web code could be updated to find the rhamt-cli during startup based upon some substitution property in the properties file (windupweb.properties for tests)?

@mareknovotny
Copy link
Contributor Author

oh, well. I forgot that maven-dependency-plugin does only one thing at time. I keep forgetting on bad documentation which can confuse the user as it could do both unpack and change the unpacked target directory. My bad.

@mareknovotny
Copy link
Contributor Author

retest

@mareknovotny mareknovotny merged commit dffa5a0 into windup:master Jun 13, 2017
@mareknovotny mareknovotny deleted the WINDUP-1433 branch June 14, 2017 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready to Review
Projects
None yet
Milestone
No milestone
2 participants
@mareknovotny @jsight