WINDUP-1447 Cancelling a file upload breaks the application #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klinki
reviewed
Jun 15, 2017
| this.onCompleteItem(item, response, status, headers); | ||
| if (!item.isCancel) { | ||
| this.onCompleteItem(item, response, status, headers); | ||
| } |
There was a problem hiding this comment.
I think this solution is reasonable.
IMHO it is nonsense to call onCompleteItem when upload is canceled or an error occurs, but it it the way original ng2-file-upload library had it so I kept it when I wrote this wrapper.
For me 👍
btw maybe item._onComplete shouldn't be called either?
|
With last commit, as @klinki suggested, also |
|
Seems to work well here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.