Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINDUP-1573: reformat error from parsing custom ruleset #494

Merged
merged 1 commit into from
Sep 14, 2017
Merged

WINDUP-1573: reformat error from parsing custom ruleset #494

merged 1 commit into from
Sep 14, 2017

Conversation

mareknovotny
Copy link
Contributor

@mareknovotny mareknovotny requested a review from jsight July 28, 2017 15:29
@mareknovotny
Copy link
Contributor Author

screenshot from 2017-07-28 17-30-47

@mareknovotny mareknovotny requested a review from mrizzi July 31, 2017 09:04
@mareknovotny
Copy link
Contributor Author

@Maarc can you look at the screenshot above, if that is ok?

@mareknovotny
Copy link
Contributor Author

retest

@mareknovotny
Copy link
Contributor Author

@jsight I think we should not wait anymore and merge this PR as the feedback seems won't come until it is in ;).

@mareknovotny mareknovotny merged commit 932e232 into windup:master Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsight jsight Awaiting requested review from jsight

@mrizzi mrizzi Awaiting requested review from mrizzi

Assignees
No one assigned
Labels
Ready to Review
Projects
None yet
Milestone
No milestone
1 participant
@mareknovotny