WINDUP-1896: advanced options in analysis config are updated immediat…

[m-brophy]

…ely without use of page save, cancel etc buttons

[jsight]

This change doesn't seem quite right to me. This disables the dirty checking for advanced options, which disables the unsaved changes warning, and by extension of that it does disable the saving of advanced options.

However, if you change any other option (for example, the cloud readiness checkbox), the warning is still displayed and the changes are still incorrectly persisted.

I think instead of this fix, the dialog box itself is the problem. It seems to always call "save" when "yes" is clicked in the confirmation dialog. But in reality, this dialog is being overloaded with two different functions. In one case, "yes" should save, and in the other it should not.

Dialog and subscription:
https://github.com/windup/windup-web/blob/master/ui/src/main/webapp/src/app/analysis-context/analysis-context-form.component.ts#L107

Subscription Behavior:
https://github.com/windup/windup-web/blob/master/ui/src/main/webapp/src/app/analysis-context/analysis-context-form.component.ts#L134

Dialog where proceed should save:
https://github.com/windup/windup-web/blob/master/ui/src/main/webapp/src/app/analysis-context/analysis-context-form.component.ts#L308

Dialog where proceed should NOT save:
https://github.com/windup/windup-web/blob/master/ui/src/main/webapp/src/app/shared/confirm-deactivate.guard.ts#L14

Because these end up using the same dialog, the first subscription is called resulting in a save operation. Oops!

This is the part that seems to need a fix, IMO.

[m-brophy]

Adjusted to use the dialog subscription model

[jsight]

This fixes the problem with that cancellation dialog, but introduces a new problem. Steps to reproduce:

1. Go to the project list and click "New Project"
2. Give the project a name and click "Next"
3. Upload a file or two (preferably a relatively large file) and click "Next"
4. Click "Save & Continue" before the packages finish loading.
5. A dialog box will appear, but nothing will allow you to finish the save and continue as this dialog is now broken.

[m-brophy]

The two dialogs no longer interfere with each other