Selenium testing #587
Closed
Selenium testing #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
retest |
|
@elisedd please 1. push a commit which removes .recommenders and then push another commit on top of that that adds .recommenders to the gitignore file. |
jeichler
reviewed
Aug 7, 2018
| /* | ||
| * step 02 | ||
| */ | ||
| // have to click cancel twice to get out of the name input |
There was a problem hiding this comment.
actually this should not be the case, right? Is that an error in the UI? then it should fail instead and we should log a ticket?
There was a problem hiding this comment.
Yes of course - https://issues.jboss.org/browse/WINDUP-2154
|
Sorry about this Janine, with Selenium there is no way to actually test
that the name input box is automatically selected when moving to the page.
It isn't really a bug with the code just a limitation of Selenium.
(Apologies if I am unnecessarily explaining things)
Selenium has 3 methods to check the status of a web element,
".isSelected()", ".isEnabled()", ".isDisplayed()". The ".isDisplayed()"
method of course works, but I was hoping for the "isSelected()" method to
return true.
At the moment I just have it looking for the actual element.
I wrote a method to test this, then just left it for if selenium is updated
so that we all know that this should ultimately be tested, I should have
written more comments explaining this.
…On Tue, Aug 7, 2018 at 12:13 PM, Janine Eichler ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ui/src/test/org/jboss/windup/web/selenium/Selenium01Test.java
<#587 (comment)>:
> + */
+ assertEquals("http://127.0.0.1:8080/rhamt-web/project-list", selenium.checkURL());
+
+ selenium.clickNewProjButton();
+ assertEquals("http://127.0.0.1:8080/rhamt-web/wizard/create-project", selenium.checkURL());
+
+ //checks that the project name field has focus, then the cancel/next buttons are enabled/disabled
+ //.nameInputSelected does not work
+ assertTrue(selenium.nameInputSelected());
+ assertTrue(selenium.cancelEnabled());
+ assertFalse(selenium.nextEnabled());
+
+ /*
+ * step 02
+ */
+ // have to click cancel twice to get out of the name input
actually this should not be the case, right? Is that an error in the UI?
then it should fail instead and we should log a ticket?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#587 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ali5QLVP8mzACKQ4V6vGRxLuf4KCcqIPks5uObyPgaJpZM4ViCkT>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.