Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Webpack Build error on production #623

Merged
merged 12 commits into from Dec 2, 2019
Merged

Fix Webpack Build error on production #623

merged 12 commits into from Dec 2, 2019

Conversation

carlosthe19916
Copy link
Member

@carlosthe19916 carlosthe19916 commented Nov 21, 2019 •
edited

  • Upgraded Webpack to v4
  • Updated because of syntax warnings
  • Update Webpack configuration files
  • Change ngtools.AotPlugin by ngtools.AngularCompilerPlugin because of Angular7 compatibility problems

@mrizzi mrizzi removed their assignment Nov 25, 2019
@mrizzi mrizzi self-requested a review November 25, 2019 10:53
@mrizzi
Copy link
Member

mrizzi commented Nov 25, 2019

retest

This was referenced Nov 25, 2019
Merged
Merged
Closed
mrizzi
mrizzi approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests have been done the last week thanks to @m-brophy and @PhilipCattanach.
Everything worked for me as well.

Thanks @carlosthe19916 for fixing this 👍

@mrizzi mrizzi merged commit c3fbcbe into windup:master Dec 2, 2019
@carlosthe19916 carlosthe19916 deleted the fixBuildProductionWebpack branch November 21, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrizzi mrizzi mrizzi approved these changes

Assignees
No one assigned
Labels
Ready to Review
Projects
None yet
Milestone
No milestone
2 participants
@carlosthe19916 @mrizzi