Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUP-2866: New PF4 UI : Add Quarkus and Spring icons #686

Merged
merged 1 commit into from Nov 18, 2020

Conversation

carlosthe19916
Copy link
Member

@carlosthe19916 carlosthe19916 commented Nov 18, 2020

https://issues.redhat.com/browse/WINDUP-2866

Added icons for "Quarkus" and "Red Hat Runtimes" cards:

Screenshot from 2020-11-18 10-29-30

@mrizzi mrizzi requested review from m-brophy and removed request for mrizzi November 18, 2020 10:18
Copy link
Contributor

@m-brophy m-brophy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2020-11-18 11-28-36
we don't have options for the same analysis targets in old UI

@carlosthe19916
Copy link
Member Author

Screenshot from 2020-11-18 11-28-36
we don't have options for the same analysis targets in old UI

@m-brophy there was no requirement to have the new Options (from Patternfly 4) in the old UI. I don't think we should spend time on it since the old UI will be deprecated soon (I hope)

@m-brophy m-brophy merged commit cad75a4 into windup:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants