[WINDUP-3205] Migrate to JDK11

[jmle]

See Jira ticket.

[windupgithubbot1]

Can one of the admins verify this patch?

[carlosthe19916]

@jmle I've seen you have deleted all the content of tests/e2e and as we discussed internally it makes sense because it includes a set of unreliable tests against the old UI based on Patternfly 3. However, do you think that rather than deleting the code it might be worth just not including the maven module tests/e2e? I mean, just to comment the line of code https://github.com/windup/windup-web/blob/master/tests/pom.xml#L20 . I'd like to know what is your opinion on this.

My apologies if it is premature to review the PR, I've just seen your great work and couldn't avoid taking a look at it.

[jmle]

@jmle I've seen you have deleted all the content of tests/e2e and as we discussed internally it makes sense because it includes a set of unreliable tests against the old UI based on Patternfly 3. However, do you think that rather than deleting the code it might be worth just not including the maven module tests/e2e? I mean, just to comment the line of code https://github.com/windup/windup-web/blob/master/tests/pom.xml#L20 . I'd like to know what is your opinion on this.

My apologies if it is premature to review the PR, I've just seen your great work and couldn't avoid taking a look at it.

Hey @carlosthe19916, thanks for your comment! From my point of view, dead code should simply be removed, otherwise it adds unnecessary complexity to the project. Should we ever need to go back to this piece of code, we can always checkout a specific commit and pick it. But if you guys have reasons for keeping the module, I can always bring it back.

PD: dead code can also be disorienting for contributors or newcomers!