Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WINDUP-3892] - Upgrade htmlUnit dependency #925

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

carlosthe19916
Copy link
Member

@carlosthe19916 carlosthe19916 commented Jun 7, 2023

https://issues.redhat.com/browse/WINDUP-3892

The direct dependency injecting the htmlunit dependency is org.jboss.arquillian.graphene:graphene-webdriver:2.5.4 and we are already using the latest stable version of it https://mvnrepository.com/artifact/org.jboss.arquillian.graphene/graphene-webdriver . Therefore, as we can no upgrade the direct dependency, we need to exclude the htmlunit dependency from org.jboss.arquillian.graphene:graphene-webdriver:2.5.4 and inject it as a direct dependency

@carlosthe19916 carlosthe19916 added auto-backport Set the PR for being backported auto-backport-to-releases/6.2.z Backport this issue to releases/6.2.z branch labels Jun 7, 2023
@mrizzi mrizzi self-requested a review June 7, 2023 13:01
Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just figured out a small enhancement.

ui-pf4/pom.xml Show resolved Hide resolved
Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @carlosthe19916

@mrizzi mrizzi merged commit 9277950 into windup:master Jun 9, 2023
5 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 9, 2023
* set Upgrade htmlunit dependency

* Set scope:test

(cherry picked from commit 9277950)
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

💚 All backports created successfully

Status Branch Result
releases/6.2.z

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

mrizzi pushed a commit that referenced this pull request Jun 12, 2023
* set Upgrade htmlunit dependency

* Set scope:test

(cherry picked from commit 9277950)

Co-authored-by: Carlos E. Feria Vila <carlosthe19916@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.2.z Backport this issue to releases/6.2.z branch
Projects
None yet
2 participants