Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUP-4115 CVE upgrade css-tools #983

Merged
merged 2 commits into from
May 10, 2024
Merged

Conversation

@m-brophy m-brophy added Ready to Review auto-backport Set the PR for being backported auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch labels May 10, 2024
@@ -5,6 +5,7 @@
"proxy": "http://localhost:8080",
"homepage": "./",
"dependencies": {
"@adobe/css-tools": "^4.3.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is not a direct dependency for the UI. It is better to set this line under the resolutions section of the package.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line has been moved as suggested

Copy link
Member

@carlosthe19916 carlosthe19916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as windup/windup#1739

Copy link
Member

@carlosthe19916 carlosthe19916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @m-brophy

@m-brophy m-brophy merged commit b136f5a into windup:master May 10, 2024
5 checks passed
github-actions bot pushed a commit that referenced this pull request May 10, 2024
* WINDUP-4115 CVE upgrade css-tools

* WINDUP-4115 place css-tools in resolutions section

(cherry picked from commit b136f5a)
Copy link

💚 All backports created successfully

Status Branch Result
releases/6.3.z

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

m-brophy added a commit that referenced this pull request May 10, 2024
* WINDUP-4115 CVE upgrade css-tools

* WINDUP-4115 place css-tools in resolutions section

(cherry picked from commit b136f5a)

Co-authored-by: Mark Brophy <36955467+m-brophy@users.noreply.github.com>
@m-brophy m-brophy deleted the WINDUP-4155 branch May 10, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch Ready to Review
Projects
None yet
2 participants