Skip to content

Commit

Permalink
Change 'faraday_middleware' to runtime dependency
Browse files Browse the repository at this point in the history
In the README, it is documented that this gem needs "faraday_middleware" gem installed.
We should make it a runtime dependency so that people don't have to specify it explicitly, or don't accidentally remove "faraday_middleware"

For the context: in our repo, we have "faraday_middleware" installed because it's the dependency of another gem. When we removed that gem we almost accidentally remove "faraday_middleware". Only upon reading README of "faraday_middleware-aws-sigv4" do we realize it is still needed
  • Loading branch information
hdoan741 committed Apr 30, 2020
1 parent 1eaeb64 commit d4d3c87
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions faraday_middleware-aws-sigv4.gemspec
Expand Up @@ -24,8 +24,8 @@ Gem::Specification.new do |spec|

spec.add_dependency 'faraday', '>= 0.15'
spec.add_dependency 'aws-sigv4', '~> 1.0'

spec.add_development_dependency 'faraday_middleware'
spec.add_dependency 'faraday_middleware', '>= 0.12'

spec.add_development_dependency 'bundler'
spec.add_development_dependency 'rake'
spec.add_development_dependency 'rspec', '~> 3.0'
Expand Down

0 comments on commit d4d3c87

Please sign in to comment.