Retry put_record_batch when the server gives response with error. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@winebarrel Hi, here's my PR for adding retry feature for kinesis firehose and would be great if I can use this feature for myself! Thanks |
|
@winebarrel is it possible to get this released ? you have any comments? |
|
Thank you for pull request! I'm sorry reply late. |
winebarrel
pushed a commit
that referenced
this pull request
Dec 9, 2015
Retry put_record_batch when the server gives response with error.
|
v0.1.2.beta has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changed put_record_batch() to retry when the server gives response with error, as currently it does not handle any failed requests.