This repository has been archived by the owner on Aug 14, 2021. It is now read-only.
Fix assign_deep testcase #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p' testcase from HashiCorp
|
I didn't realize that the rhcl parser was a direct copy of the one in the Go library. I now see that this isn't part of the grammar (though I'm not sure why). I'll withdraw the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow an object to be a member of a list, which fixes the 'assign_deep' testcase from HashiCorp
This was an expected fail in the master version of the gem; the fix seems fairly simple so I'm not sure if I'm missing something, but all existing specs test and assign_deep now works as expected compared to the Go version.