Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial: Connected Components #659

Closed
wants to merge 4 commits into from
Closed

tutorial: Connected Components #659

wants to merge 4 commits into from

Conversation

Mr-ram99
Copy link

@Mr-ram99 Mr-ram99 commented Oct 2, 2023

Change Summary

Tutorial write-up: Connected Components (closes: #107)

Checklist

If you haven't fulfilled the below requirements or even delete the entire checklist, your PR won't be reviewed and will be closed without notice. Regular contributors (with 10+ PRs) can skip this part.

General

  • This Pull Request is all my own work. (You'll be blacklisted if you are caught for plagiarism.)
  • I've read CONTRIBUTING.md
  • I've applied LaTex for all variables, formulas and time / space complexity instead of using backticks
  • I've started the app locally and verified all the content and all links (if applicable) are accessible correctly
  • I've included Complexity Analysis (Time Complexity & Space Complexity).
  • I've written my explanation well and it is easy to understand for beginners

Tutorial

  • I've read and followed the Tutorial Template
  • I've explained my topic well with 2 - 3 LC problems and no external problems are used.
  • I've provided the full working solutions to the problems used in this tutorial.
  • I've provided suggested problems at the end with the given format. See here as an example. If the target solution is not available, leave solutionLink blank.
  • I've given credits / references if I use external resources. (For an image, give credit under it. Otherwise, add a new section called References at the end (after Suggested Problems).)

Solutions

  • I've read and followed the Solution Template
  • I've formatted my code well with K&R Coding style
  • I've confirmed that comments are put above each line rather than writing on the same line.
  • I've included a meaningful approach name for my solution. e.g. ## Approach 1: Two Pointers.

Copy link
Owner

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look at the checklist again please.

@Mr-ram99
Copy link
Author

Mr-ram99 commented Oct 3, 2023

can you please review now.

Copy link
Owner

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've explained my topic well with 2 - 3 LC problems and no external problems are used.

you sure?

@Mr-ram99
Copy link
Author

Mr-ram99 commented Oct 3, 2023

okay I'm adding one more example with explaination. I thought one example will be fine as it is a simple topic. One question, what if I want to add some static images (not from external resources, I'll create the images) into the tutorial? In which folder should i store them ? should I store in static/img ?

@wingkwong
Copy link
Owner

I thought one example will be fine as it is a simple topic.

I would expect a long detailed tutorial rather some codes with simple steps. Also your code is not following K&R Coding style.

One question, what if I want to add some static images (not from external resources, I'll create the images) into the tutorial? In which folder should i store them ? should I store in static/img ?

already answered in CONTRIBUTING.md

@Mr-ram99 Mr-ram99 closed this by deleting the head repository Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial Writeup : Connected Components
2 participants