Skip to content

Commit

Permalink
chore: workflow and dep vulnerability update (#2577)
Browse files Browse the repository at this point in the history
In response to a security advisory from github:

- The self-mutation workflow effectively allowed for shell injection via branch name, so it was updated to avoid that
- `npm audit fix` for all packages. This updated vm2 as well as projen. The projen update needed a change to make sure it handled our `.npmrc`. Other than that the projen update itself changed several files but things look good
- In the winglang package, had to add esbuild as an explicit dev dependency. In theory, vitest already handles this, but I noticed all the optional system-specific dependencies of esbuild were removed from the lockfile. Not sure what changed, but adding esbuild explicitly doesn't hurt our dependency closure anyways


*By submitting this pull request, I confirm that my contribution is made under the terms of the [Monada Contribution License](https://docs.winglang.io/terms-and-policies/contribution-license.html)*.
  • Loading branch information
MarkMcCulloh committed May 21, 2023
1 parent 62dabde commit 05d09f7
Show file tree
Hide file tree
Showing 51 changed files with 11,410 additions and 4,287 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/wingsdk-mutation.yml
Expand Up @@ -65,8 +65,10 @@ jobs:
git diff --staged --patch --exit-code > /dev/null || echo "::set-output name=self_mutation_happened::true"
- name: Push changes
if: steps.token-check.outputs.HAS_TOKEN == 'true' && steps.self_mutation.outputs.self_mutation_happened
env:
HEAD_REF: ${{ github.event.pull_request.head.ref }}
run: |-
git config user.name "monada-bot[bot]"
git config user.email "monabot@monada.co"
git commit -s -m "chore: self mutation"
git push origin HEAD:${{ github.event.pull_request.head.ref }}
git push origin HEAD:$HEAD_REF
4 changes: 1 addition & 3 deletions apps/jsii-docgen/.eslintrc.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion apps/jsii-docgen/.gitattributes

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion apps/jsii-docgen/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/jsii-docgen/.npmignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions apps/jsii-docgen/.npmrc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/jsii-docgen/.prettierignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 3 additions & 7 deletions apps/jsii-docgen/.projen/deps.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion apps/jsii-docgen/.projen/files.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 19 additions & 1 deletion apps/jsii-docgen/.projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions apps/jsii-docgen/.projenrc.ts
Expand Up @@ -65,4 +65,7 @@ project.addFields({
volta: rootPackageJson.volta,
});

// We use of symlinks between several projects but we do not use workspaces
project.npmrc.addConfig("install-links", "false");

project.synth();

0 comments on commit 05d09f7

Please sign in to comment.