Skip to content

Commit

Permalink
chore(sdk): use cloud.Function instead of sim.Function (#6544)
Browse files Browse the repository at this point in the history
Gives platforms a chance to override the default sim function

## Checklist

- [ ] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [ ] Description explains motivation and solution
- [ ] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
  • Loading branch information
eladcon committed May 23, 2024
1 parent fdc0477 commit ffc070d
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 8 deletions.
2 changes: 1 addition & 1 deletion libs/wingsdk/src/target-sim/api.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { Construct } from "constructs";
import { App } from "./app";
import { EventMapping } from "./event-mapping";
import { Function } from "./function";
import { Policy } from "./policy";
import { ISimulatorResource } from "./resource";
import { ApiRoute, ApiSchema } from "./schema-resources";
import { simulatorAttrToken } from "./tokens";
import { bindSimulatorResource, makeSimulatorJsClient } from "./util";
import { Function } from "../cloud";
import * as cloud from "../cloud";
import { lift } from "../core";
import { ToSimulatorOutput } from "../simulator/simulator";
Expand Down
7 changes: 2 additions & 5 deletions libs/wingsdk/src/target-sim/queue.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import { Construct } from "constructs";
import { App } from "./app";
import { EventMapping } from "./event-mapping";
import {
Function,
FunctionInflightMethods as SimFunctionInflightMethods,
} from "./function";
import { FunctionInflightMethods as SimFunctionInflightMethods } from "./function";
import { Policy } from "./policy";
import { ISimulatorResource } from "./resource";
import { QueueSchema } from "./schema-resources";
Expand Down Expand Up @@ -80,7 +77,7 @@ export class Queue extends cloud.Queue implements ISimulatorResource {
props: cloud.QueueSetConsumerOptions = {}
): cloud.Function {
const functionHandler = QueueSetConsumerHandler.toFunctionHandler(inflight);
const fn = new Function(
const fn = new cloud.Function(
this,
App.of(this).makeId(this, "Consumer"),
functionHandler,
Expand Down
2 changes: 1 addition & 1 deletion libs/wingsdk/src/target-sim/schedule.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { Construct } from "constructs";
import { App } from "./app";
import { EventMapping } from "./event-mapping";
import { Function } from "./function";
import { Policy } from "./policy";
import { ISimulatorResource } from "./resource";
import { ScheduleSchema } from "./schema-resources";
Expand All @@ -10,6 +9,7 @@ import {
makeSimulatorJsClient,
convertDurationToCronExpression,
} from "./util";
import { Function } from "../cloud";
import * as cloud from "../cloud";
import { lift } from "../core";
import { ToSimulatorOutput } from "../simulator";
Expand Down
2 changes: 1 addition & 1 deletion libs/wingsdk/src/target-sim/topic.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { Construct } from "constructs";
import { App } from "./app";
import { EventMapping } from "./event-mapping";
import { Function } from "./function";
import { Policy } from "./policy";
import { ISimulatorResource } from "./resource";
import { TopicSchema } from "./schema-resources";
import { bindSimulatorResource, makeSimulatorJsClient } from "./util";
import { Function } from "../cloud";
import * as cloud from "../cloud";
import { lift, LiftMap } from "../core";
import { ToSimulatorOutput } from "../simulator";
Expand Down

0 comments on commit ffc070d

Please sign in to comment.