Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class Declaration: super #1123

Closed
3 tasks
Tracked by #460
eladb opened this issue Jan 11, 2023 · 1 comment · Fixed by #2905
Closed
3 tasks
Tracked by #460

Class Declaration: super #1123

eladb opened this issue Jan 11, 2023 · 1 comment · Fixed by #2905
Assignees
@hasanaburayyan
Labels
🛠️ compiler Compiler 📜 lang-spec-impl Appears in the language spec roadmap

Comments

@eladb
Copy link
Contributor

eladb commented Jan 11, 2023 •
edited by yoav-steinberg

https://github.com/winglang/wing/blob/main/docs/04-reference/winglang-spec.md#32-classes

Add support for calling super(...) in inheriting classes' init

verify that:

  • user defined resource can inherit from about user defined resource.
  • child resource's client class has access to parent's client fields.
  • inflight init in child is called after inflight init in parent is called.
@eladb eladb mentioned this issue Jan 11, 2023
Closed
7 tasks
@eladb eladb changed the title Add support for calling super(...) in inheriting classes' init super Jan 11, 2023
@staycoolcall911 staycoolcall911 added 📜 lang-spec-impl Appears in the language spec roadmap 🛠️ compiler Compiler labels Jan 15, 2023
@staycoolcall911 staycoolcall911 changed the title super Class Declaration: super Jan 15, 2023
@staycoolcall911 staycoolcall911 mentioned this issue Feb 14, 2023
Closed
@guywaldman guywaldman mentioned this issue Feb 15, 2023
Closed
@yoav-steinberg yoav-steinberg mentioned this issue Apr 13, 2023
Merged
1 task
@hasanaburayyan hasanaburayyan self-assigned this May 30, 2023
@hasanaburayyan hasanaburayyan mentioned this issue Jun 13, 2023
Merged
5 tasks
@mergify mergify bot closed this as completed in #2905 Jun 21, 2023
mergify bot pushed a commit that referenced this issue Jun 21, 2023
@hasanaburayyan
feat(compiler): add support for super constructor (#2905)
3ffe46e 
Adds support for calling super()  constructor within derived class initializer.

Closes: #1123

## MISC:
- fixed latent bug where inflight client super constructor calls were not wrapping args as an object
- some minor refactors and cleanups

## Checklist

- [x] Title matches [Winglang's style guide](https://docs.winglang.io/contributors/pull_requests#how-are-pull-request-titles-formatted)
- [x] Description explains motivation and solution
- [x] Tests added (always)
- [x] Docs updated (only required for features)
- [x] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Monada Contribution License](https://docs.winglang.io/terms-and-policies/contribution-license.html)*.
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.21.23.

eladb pushed a commit that referenced this issue Jun 22, 2023
@hasanaburayyan @eladb
feat(compiler): add support for super constructor (#2905)
edcef1b 
Adds support for calling super()  constructor within derived class initializer.

Closes: #1123

- fixed latent bug where inflight client super constructor calls were not wrapping args as an object
- some minor refactors and cleanups

- [x] Title matches [Winglang's style guide](https://docs.winglang.io/contributors/pull_requests#how-are-pull-request-titles-formatted)
- [x] Description explains motivation and solution
- [x] Tests added (always)
- [x] Docs updated (only required for features)
- [x] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Monada Contribution License](https://docs.winglang.io/terms-and-policies/contribution-license.html)*.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hasanaburayyan hasanaburayyan

Labels
🛠️ compiler Compiler 📜 lang-spec-impl Appears in the language spec roadmap
Projects
Wing
Archived in project
Wing Language Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(compiler): add support for super constructor winglang/wing
6 participants
@eladb @revitalbarletz @GuyDev1 @hasanaburayyan @staycoolcall911 @monadabot