Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface Declaration #123

Closed
Tracked by #194
staycoolcall911 opened this issue Sep 20, 2022 · 2 comments · Fixed by #1938
Closed
Tracked by #194

Interface Declaration #123

staycoolcall911 opened this issue Sep 20, 2022 · 2 comments · Fixed by #1938
Assignees
@Chriscbr @staycoolcall911
Labels
🛠️ compiler Compiler 📜 lang-spec-impl Appears in the language spec roadmap

Comments

@staycoolcall911
Copy link
Contributor

staycoolcall911 commented Sep 20, 2022 •
edited

https://github.com/winglang/wing/blob/main/docs/04-reference/winglang-spec.md#34-interfaces
@staycoolcall911 staycoolcall911 added the 📜 lang-spec-impl Appears in the language spec roadmap label Sep 20, 2022
@Chriscbr Chriscbr mentioned this issue Sep 27, 2022
Closed
36 tasks
@Chriscbr Chriscbr added the 🛠️ compiler Compiler label Sep 28, 2022
@yoav-steinberg yoav-steinberg mentioned this issue Dec 20, 2022
Closed
16 tasks
@github-actions
Copy link

Hi,

This issue hasn't seen activity in 60 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days.
Feel free to re-open this issue when there's an update or relevant information to be added.
Thanks!

@github-actions github-actions bot added the Stale label Jan 27, 2023
@staycoolcall911 staycoolcall911 mentioned this issue Feb 7, 2023
Merged
@staycoolcall911 staycoolcall911 mentioned this issue Feb 20, 2023
Closed
@staycoolcall911 staycoolcall911 self-assigned this Mar 22, 2023
@staycoolcall911 staycoolcall911 mentioned this issue Apr 2, 2023
Merged
4 tasks
@mergify mergify bot closed this as completed in #1938 Apr 2, 2023
mergify bot pushed a commit that referenced this issue Apr 2, 2023
@staycoolcall911
feat(compiler): interface declaration (#1938)
7e12b93 
This PR adds support for `interface` according to the [spec](https://docs.winglang.io/reference/spec#34-interfaces).

Also in this PR:
- [x] Removed interface fields from the spec and our codebase ([slack discussion](https://winglang.slack.com/archives/C048QCN2XLJ/p1680077416200329)).
- [x] Removed access modifiers from interface methods (to comply with the spec).
- [x] (Very) small refactoring in our grammar.js to rename method return type from `type` to `return_type`.
- [x] Removed unused parameter `is_class` from SymbolEnv::new

Fixes #123

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Monada Contribution License](https://docs.winglang.io/terms-and-policies/contribution-license.html)*.
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.8.23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chriscbr Chriscbr

@staycoolcall911 staycoolcall911

Labels
🛠️ compiler Compiler 📜 lang-spec-impl Appears in the language spec roadmap
Projects
Wing
Archived in project
Wing Language Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(compiler): interface declaration winglang/wing
3 participants
@Chriscbr @staycoolcall911 @monadabot