Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing SDK spec tests #3358

Closed
1 task
tsuf239 opened this issue Jul 11, 2023 · 1 comment
Closed
1 task

missing SDK spec tests #3358

tsuf239 opened this issue Jul 11, 2023 · 1 comment
Labels
✨ enhancement New feature or request 🎨 sdk SDK 🧪 testing

Comments

@tsuf239
Copy link
Collaborator

tsuf239 commented Jul 11, 2023 •
edited by staycoolcall911

Feature Spec

  • QueueProps.retentionPeriod

Use Cases

sdk spec testing

Implementation Notes

No response

Component

SDK

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
@tsuf239 tsuf239 added the ✨ enhancement New feature or request label Jul 11, 2023
@tsuf239 tsuf239 mentioned this issue Jul 11, 2023
Merged
5 tasks
mergify bot pushed a commit that referenced this issue Jul 12, 2023
@tsuf239
fix(examples, sdk): fixing sdk spec tests (#3357)
1c81ccc 
## Description
Finally closes #2114 !!
1. handled tests: 
* hidden: api/ delete, patch, option, get, put, post - #3342
* hidden: bucket/events - #2724
* hidden: queue/timeout - #3354 
* fixed: counter/dec - there was a bug working with both key and initial key different than 0
* fixed: function/memory_and_env- adjusted test
* fixed: function/timeout- adjusted test
* fixed- table/add_row - the key wasn't saved in the object when adding a key on preflight on sim, fixed and adjusted test
* fixed - website/website - adjusted test
* fixed - util/env- adjusted test, since utils.env is working, it is just that the meta comments aren't followed when using the cli and not hangar

2. Run build to generate new snapshots
3. edited the compatibility matrix - leftover tests detected: #3358
 
## Checklist

- [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [x] Description explains motivation and solution
- [x] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Monada Contribution License](https://www.winglang.io/terms-and-policies/contribution-license.html)*.
@staycoolcall911
Copy link
Contributor

This is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ enhancement New feature or request 🎨 sdk SDK 🧪 testing
Projects
Wing
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsuf239 @staycoolcall911