Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws.xxxRef Resources Creates Unneeded TF Resources For tf-aws #6383

Closed
hasanaburayyan opened this issue Apr 30, 2024 · 5 comments · Fixed by #7013
Closed

aws.xxxRef Resources Creates Unneeded TF Resources For tf-aws #6383

hasanaburayyan opened this issue Apr 30, 2024 · 5 comments · Fixed by #7013
Labels
🐛 bug Something isn't working 🏎️ perf Related to performance 🎨 sdk SDK

Comments

@hasanaburayyan
Copy link
Contributor

I tried this:

bring aws;

new aws.BucketRef("blah");

wing compile -t tf-aws

THEN

tf apply

This happened:

~40 some resources are going to be made
image

I expected this:

No resources

Is there a workaround?

No response

Anything else?

I think this is because the ui fields we add for interacting with Refs in the simulator, and they are being turned into lambda functions in AWS

Wing Version

No response

Node.js Version

No response

Platform(s)

No response

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
@hasanaburayyan hasanaburayyan added 🐛 bug Something isn't working 🎨 sdk SDK labels Apr 30, 2024
@eladb
Copy link
Contributor

eladb commented May 1, 2024

Oh, seems like this is the resources used for the ui elements, no @Chriscbr ?

@Chriscbr
Copy link
Contributor

Chriscbr commented May 1, 2024

Oh, seems like this is the resources used for the ui elements, no @Chriscbr ?

Yup 👍

Perhaps for now we can disable the ui elements from creating various child resources when you're compiling to non-sim targets, since Wing Console only works with simulated apps at the moment. ie

if app.target != "sim" {
  // existing logic
}

@eladb
Copy link
Contributor

eladb commented May 1, 2024

👍

@staycoolcall911 staycoolcall911 added the 🏎️ perf Related to performance label May 9, 2024
Copy link

github-actions bot commented Aug 8, 2024

Hi,

This issue hasn't seen activity in 90 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days.
Feel free to re-open this issue when there's an update or relevant information to be added.
Thanks!

@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.82.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🏎️ perf Related to performance 🎨 sdk SDK
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants