Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connections to hidden child don't show connection to parent #6523

Closed
MarkMcCulloh opened this issue May 20, 2024 · 5 comments · Fixed by #6569
Closed

Connections to hidden child don't show connection to parent #6523

MarkMcCulloh opened this issue May 20, 2024 · 5 comments · Fixed by #6569
Assignees
Labels
🐛 bug Something isn't working 🛫 console Console

Comments

@MarkMcCulloh
Copy link
Contributor

I tried this:

class Node {}

let a = new Node() as "a";
let b = new Node() as "b";
let c = new Node() as "c" in b;

nodeof(a).addConnection(
  name: "1",
  source: a,
  target: c,
);

// nodeof(c).hidden = true;

playground link

This happened:

image

Hiding "c" (nodeof(c).hidden = true;) loses the connection entirely

image

Now it's not clear the a and b are technically related

I expected this:

Some sort of connection between a and b

Is there a workaround?

No response

Anything else?

No response

Wing Version

No response

Node.js Version

No response

Platform(s)

No response

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
@MarkMcCulloh MarkMcCulloh added 🐛 bug Something isn't working 🛫 console Console labels May 20, 2024
@ekeren
Copy link
Collaborator

ekeren commented May 20, 2024

+100

@skyrpex skyrpex self-assigned this May 24, 2024
@skyrpex
Copy link
Contributor

skyrpex commented May 24, 2024

I see! Will fix soon.

@eladb
Copy link
Contributor

eladb commented May 25, 2024

+1

@ainvoner
Copy link
Contributor

@skyrpex @polamoros sync on this one since I guess you will need the same logic when the resources will be collapsed

@mergify mergify bot closed this as completed in #6569 May 27, 2024
mergify bot pushed a commit that referenced this issue May 27, 2024
This change resolves connections to hidden nodes upwards, meaning that the connection will be listed to its closest visible parent node.

Fixes #6523.
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.74.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🛫 console Console
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants