feat(compiler): static support #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
reviewed
Feb 24, 2023
The information was already saved in the env's `VariableInfo`.
Chriscbr
requested changes
Feb 24, 2023
Co-authored-by: Chris Rybicki <chrisr@monada.co>
Co-authored-by: Chris Rybicki <chrisr@monada.co>
Chriscbr
approved these changes
Feb 27, 2023
yoav-steinberg
added
the
🚧 pr/do-not-merge
|
Congrats! 🚀 This was released in Wing 0.5.81. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #107
also in this PR:
IndexSetinstead of aVec.TypeMemberfor referencing enum fields and class statics. Currently the grammar has no way of distinguishing between a nested reference and a type property reference. So during type-checking I do a (unsafe) convert in the AST tree from one type to the other. If we change the grammar to distinguish between the two we can avoid the unsafe here.Reference::NestedReferecetoReference::InstanceMemberto match nicely with the newReference::TypeMember.Not in this PR
staticresource members from inflight #1669)By submitting this pull request, I confirm that my contribution is made under the terms of the Monada Contribution License.