feat(vscode): symbol and property completions

[MarkMcCulloh]

Misc

Parser Changes

• More surgical usage of tree-sitter errors. We no longer throw away entire expressions just because they contain an error
  • This often replaces Unknown parser error with something more useful

Grammar changes

• Formated grammar.js
• The "property" part of nested identifiers is now optional (!)
  • Note, the rust parser will still fail on this. This change was made to improve the error recovery of incomplete references. We can provide a better error message than tree-sitter can. Plus, the lsp handles this better
  • Better error handling for this would require us to write our own additional tree-sitter scanner in C, which I decided to not do (cause I don't wanna)

Misc compiler change

• Made parent on SymbolEnv public
  • the usual "with_ancestry" was not good enough on iter() and it didn't seem valuable to change or make new iterators

Extension changes

• Forced the wordPattern languageConfiguration to be set for Wing in vscode, this ensures autocomplete gets triggered when typing words (without having to use a trigger character)

Corpus changes

• Due to grammar/parser changes, updated invalid examples with more focused errors

LSP changes

• When compiling for the LSP, disabled capture visiting. It seems very fragile with incomplete code so it needs to be revisited.

Main Event

Completion Support for Symbols/Properties

autocomplete.mp4

What's missing?

Lots of stuff! but I'm tired of working on this now so...

• Can't handle incomplete nested expressions, only nested identifiers
  • This is most notable for calls like a.b().
  • (sidenote) resolve_reference() really needs to be exposed outside of TypeChecker
• props/methods of generic classes/builtins are not reified (shows T1)
• Many details of various types completion types are missing
• No ordering on the locality of suggestions

[eladb]

Can't wait for this to ship!

[yoav-steinberg]

✨ amazing work.
Didn't go deeply into the lsp code cause it's a lot and I'm not too familiar with it.
I added lots of tiny nitpicks but some might be important so I'm not approving yet.

[Chriscbr]

Really looking forward to shipping this. I added some more feedback, the main one is about tests.

I also think it could be really helpful to create a tracking issue for the known gaps in the different LSP features so that we can try and identify what parts of the LSP / extension our contributors can help with, which could be good first issues, etc.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[monadabot]

Congrats! 🚀 This was released in Wing 0.5.114.