New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compiler)!: create sets with []
instead of {}
#5729
Conversation
Thanks for opening this pull request! 🎉
|
Console preview environment is available at https://wing-console-pr-5729.fly.dev 🚀 Last Updated (UTC) 2024-02-23 15:31 |
BenchmarksComparison to Baseline 🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-02-23 15:37 |
Signed-off-by: monada-bot[bot] <monabot@monada.co>
[]
instead of {}
[]
instead of {}
[]
instead of {}
Signed-off-by: monada-bot[bot] <monabot@monada.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just a couple nits and a fix for the test
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Co-authored-by: Mark McCulloh <Mark.McCulloh@gmail.com>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Co-authored-by: Mark McCulloh <Mark.McCulloh@gmail.com>
Co-authored-by: Mark McCulloh <Mark.McCulloh@gmail.com>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Thanks for contributing, @Warkanlock! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.59.0. |
Based on #4843
Description
Implemented new syntaxis for the
Set
andMutSet
keywords. From now on, sets will be defined using the identical syntaxes used for Arrays with the difference that there won't be any implicit definition of a set (before it was plain{}
)Example
I limited myself to adding more tests since this was more a functionality related to all the tests we already had in place.
By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.
BREAKING CHANGE:
Set
literal syntax ({1, 2, 3}
) is removed. Use[]
with an explicitSet<T>
instead.