-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk)!: change cloud.Function
event type from string
to Json
#6219
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! 🎉
|
Please add a detailed description and a |
0ca300d
to
7a107f3
Compare
cloud.Function
from string
to Json
cloud.Function
event input type from string
to Json
cloud.Function
event input type from string
to Json
cloud.Function
event type from string
to Json
The function invocation on AWS works now. ❯ aws lambda invoke --function-name Function-c852aba6 --payload $(echo '{ "foo": 123 }' | base64) out.json
{
"StatusCode": 200,
"ExecutedVersion": "$LATEST"
} |
Hi, This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days. |
Hi, This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days. |
Hi Gary, do you need any help with this one? |
I resolved the conflicts, but I don't have much knowledge on how the simulator resources work. Some of them require type adjusting. |
Hey Gary, I wanted to give a heads up I've started working on update this PR and fix up some of the remaining tests. Stay tuned! |
Console preview environment is available at https://wing-console-pr-6219.fly.dev 🚀 Last Updated (UTC) 2024-06-14 21:35 |
Closes #6216
BREAKING CHANGE: The input type for
cloud.Function
handlers has been changed fromstr
toJson
to align with the event formats used by major cloud providers like AWS, GCP, and Azure.This is a breaking change for any existing code that assumes the input event is a
str
.To migrate:
cloud.Function
handlers to expect aJson
value as input instead of astr
Json
valuecloud.Function
to pass inJson
values instead ofstr
Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.