Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiline variable support #12

Merged
merged 4 commits into from
Oct 6, 2020
Merged

Add multiline variable support #12

merged 4 commits into from
Oct 6, 2020

Conversation

amineck
Copy link
Contributor

@amineck amineck commented Oct 5, 2020

example:

PLAIN=plaintext
JWT_KEY="-----BEGIN PUBLIC KEY-----
MIGbMBAGByqGSM49AgEGBSuBBAAjA4GGAAQAC6vH7IGAp8pdUt92yiDGKt9mAwN3
TRT3ZSQfIk/68btXJRMBz1yqTYdjjmruG/H9uGq4N4g++djUb3k18Ep0MbsB6g+7
Dpig7Mu3Nqf3ywLsiXf1EiffYsrkUouWsjTnIYf800jl/JHHB0Gkn24td8aahE8v
5fK56W2mjskKKKCZnMc=
-----END PUBLIC KEY-----"
PLAIN2=plaintext2

@amineck amineck requested review from hebime and iToto October 5, 2020 15:08
hebime
hebime approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@hebime hebime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Looks good. My only comment would be to maybe add a constant for the multi line character ", this way if we want to support quoted text in the future we could change the multi token. Not necessary to do right now though.

iToto
iToto approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@iToto iToto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amineck amineck merged commit 6c63890 into master Oct 6, 2020
@amineck amineck deleted the multiline_vars branch October 6, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iToto iToto iToto approved these changes

@hebime hebime hebime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amineck @iToto @hebime