Update Cairo to version 1.18.0 #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbor
approved these changes
Sep 24, 2023
|
I'm not sure why the build of Pango is failing 🤔 |
danyeaw
force-pushed
the
cairo-1.18.0
branch
from
4edbee5
to
33a5905
Compare
|
|
Hey @pbor, yup, I'm not sure if this is an issue with Cairo, Pango, or Fontconfig yet. Maybe an incompatibility with Pango after the Cairo update? |
|
Yeah, not sure, I just pasted the line so we do not need to fish it in the log each time, but I am not sure how to fix :) |
|
In the mean time, we should start pushing 1507412 |
|
@pbor It looks like upgrading Pango to 1.51 did the trick |
nacho
reviewed
Oct 24, 2023
|
Awesome! thanks @danyeaw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to patch Cairo to get this to compile, and I submitted the patch upstream:
https://gitlab.freedesktop.org/cairo/cairo/-/merge_requests/520