Corrects the deallocation bug on mb_info_free and sliced threads. #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Ytsejam76, sorry we hadn't gotten to this yet. Do you still want to merge this? I saw that you closed it. |
|
I reorganized the patch into smaller commits and it was merged today as #1127
…On Mon, Nov 6, 2023 at 8:47 PM Dan Yeaw ***@***.***> wrote:
Hey @Ytsejam76 <https://github.com/Ytsejam76>, sorry we hadn't gotten to
this yet. Do you still want to merge this? I saw that you closed it.
—
Reply to this email directly, view it on GitHub
<#1123 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVYQEMCCJTW25DZ6XVX6VY3YDE5GHAVCNFSM6AAAAAA642ZHRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJWGIYTIMZVGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Oh nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for a race condition when using sliced threads. Prevents mb_info_free to be called before all the threads have finished using the data.
Submitted to x264: https://code.videolan.org/videolan/x264/-/issues/69