Update Opus to 1.5.1 #1273
Merged
Update Opus to 1.5.1 #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbor
reviewed
Mar 10, 2024
| dependencies=[ | ||
| "ninja", | ||
| "meson", | ||
| "pkgconf", | ||
| ], | ||
| ) | ||
|
|
||
| self.add_param("-Dtests=disabled") |
There was a problem hiding this comment.
can we disable tests and docs with cmake?
There was a problem hiding this comment.
Hi @pbor, thanks for the feedback. I updated the PR to disable the tests, I don't see an option to disable docs though.
nacho
approved these changes
Mar 11, 2024
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched to the CMake build since Meson is failing. I created an upstream issue about it: xiph/opus#322