Build GTK3 and GTK4 in Parallel #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyeaw
force-pushed
the
gtk4-ci-parallel
branch
from
37551b2
to
13b1fbe
Compare
danyeaw
force-pushed
the
gtk4-ci-parallel
branch
3 times, most recently
from
554b836
to
ba6ee8e
Compare
danyeaw
force-pushed
the
gtk4-ci-parallel
branch
from
4e88057
to
49ecd73
Compare
|
Even though this build worked great, I noticed we got another stuck build: I am going to make the GTK4 build passing optional until we figure out why this is flakey. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds GTK3 and GTK4 in parallel in order to add GTK4 build coverage.
I did attempt to do it in multiple stages with building the common portions first, but the supported way to do this had major performance issues using the actions/upload-artifact and actions/download-artifact GH Actions.
Putting the gvs-build directory in a tar was quick, but uploading took 15min. Compressing the directory using zstandard took greater than 30min, with similar long times with 7zip and gunzip. It looks like others have had these issues as well with actions/upload-artifact#199
I also removed pycairo and pygobject from the build pipeline because I don't think they are strictly necessary to test with the build now that installing them from PyPI is working.
Overall build time went down from 1hr to 34min with this change.